Fix glob import tests #141060
Closed
Fix glob import tests #141060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-tidy
jieyouxu
requested changes
May 16, 2025
Comment on lines
7
to
10
| mod foo { | ||
| pub use d::*; // this imports d::Foo | ||
| pub use m::Foo; // this should shadow d::Foo | ||
| } |
There was a problem hiding this comment.
Suggestion: a few things:
- Move this test to
tests/ui/resolve/, and - Rename it to sth more meaningful, like
non-glob-vs-glob-reexport-precedence - Add a doc comment to the test to back link to the issue, e.g.
//! Regression test for #14082.
| @@ -0,0 +1,38 @@ | |||
| #![allow(unused_imports, dead_code)] | |||
|
|
|||
| mod test1 { | |||
There was a problem hiding this comment.
Suggestion: can you rename these test modules as something more semantically meaningful, e.g.
test1->glob_vs_glob_ambiguitytest2->non_glob_vs_non_glob_name_collision
rustbot
added
S-waiting-on-author
jieyouxu
reviewed
May 16, 2025
There was a problem hiding this comment.
Suggestion:
- Rename this test as sth more meaningful like
import-glob-ambiguity-non-glob-collision - Ditto on the doc comment for a backlink.
|
☔ The latest upstream changes (presumably #142033) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Please address the feedback from the reviewer. Thanks! FYI: when a PR is ready for review, send a message containing |
|
At this point I think it is easier to redo the PR |
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140780 and #140765
r? jieyouxu