Do not remove super keyword from super let

[compiler-errors]

This is affecting a macro in the standard library:

rust/library/core/src/pin.rs

Line 1945 in bc7512e

super let mut pinned = $value;

I added an exception in 6f6a9a5, but I'd like to remove it eventually, so opening this in-tree to not block this on the next rustfmt sync.

r? @calebcartwright or @ytmimi

[rustbot]

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

[ytmimi]

@bors r+

[bors]

📌 Commit 26316b8 has been approved by ytmimi

It is now in the queue for this repository.

[compiler-errors]

@bors rollup

[bors]

⌛ Testing commit 26316b8 with merge f6b5da7...

[bors]

☀️ Test successful - checks-actions
Approved by: ytmimi
Pushing f6b5da7 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 32d2385 (parent) -> f6b5da7 (this PR)

Test differences

Show 33150 test diffs

Stage 1

• collections::btree::map::tests::test_iter: pass -> [missing] (J0)
• collections::btree::map::tests::test_range_large: pass -> [missing] (J0)
• collections::vec_deque::tests::issue_80303: pass -> [missing] (J0)
• collections::vec_deque::tests::test_vec_deque_truncate_drop: pass -> [missing] (J0)
• f64::test_neg_zero: pass -> [missing] (J0)
• mem::align_of_val_basic: pass -> [missing] (J0)
• net::socket_addr::is_v4: pass -> [missing] (J0)
• num::test_try_isizei32: pass -> [missing] (J0)
• num::u64::test_carrying_mul: pass -> [missing] (J0)
• slice::swap_panics::index_b_equals_len: pass -> [missing] (J0)
• slice::test_iter_clone: pass -> [missing] (J0)
• slice::test_mut_last: pass -> [missing] (J0)
• slice::test_to_vec: pass -> [missing] (J0)
• sort::tests::unstable::self_cmp_string_random_z1: pass -> [missing] (J0)
• sort::tests::unstable::stability_string_random_z1: pass -> [missing] (J0)
• str::slice_index::test_slice_fail_truncated_1: pass -> [missing] (J0)
• string::test_simple_types: pass -> [missing] (J0)
• string::test_unsized_to_string: pass -> [missing] (J0)
• sync::test_from_box: pass -> [missing] (J0)
• sys_common::wtf8::tests::wobbled_wtf8_plus_bytes_isnt_utf8: pass -> [missing] (J0)
• time::constructor_weeks: pass -> [missing] (J0)
• errors::verify_ast_passes_assoc_fn_without_body_10: pass -> [missing] (J1)
• errors::verify_ast_passes_at_least_one_trait_35: pass -> [missing] (J1)
• errors::verify_incremental_create_dep_graph_37: pass -> [missing] (J1)
• errors::verify_passes_rustc_const_stable_indirect_pairing_174: pass -> [missing] (J1)
• errors::verify_resolve_generic_arguments_in_macro_path_51: pass -> [missing] (J1)
• errors::verify_session_file_is_not_writeable_28: pass -> [missing] (J1)
• html::markdown::tests::test_markdown_html_escape: pass -> [missing] (J1)
• spec::tests::arm_linux_androideabi: pass -> [missing] (J1)
• spec::tests::riscv32em_unknown_none_elf: pass -> [missing] (J1)
• spec::tests::riscv32emc_unknown_none_elf: pass -> [missing] (J1)
• tests::test_fn_like_macro_clone_raw_ident: pass -> [missing] (J1)
• transitive_relation::tests::mubs_best_choice_scc: pass -> [missing] (J1)
• fs::tests::file_open_not_found: pass -> [missing] (J2)
• num::flt2dec::strategy::grisu::bench_big_shortest: pass -> [missing] (J2)
• os::unix::net::tests::test_unix_datagram_peek_from: pass -> [missing] (J2)
• path::bench_path_hashset_miss: pass -> [missing] (J2)
• sort::tests::stable::correct_cell_i32_descending: pass -> [missing] (J2)
• sort::tests::unstable::correct_dyn_val_random: pass -> [missing] (J2)
• sort::tests::unstable::self_cmp_cell_i32_ascending: pass -> [missing] (J2)
• sort::tests::unstable::stability_i32_random_s95: pass -> [missing] (J2)
• str::char_count::zh_huge::case03_manual_char_len: pass -> [missing] (J2)
• str::find_underscore_str::short_mixed: pass -> [missing] (J2)
• vec::bench_with_capacity_0000: pass -> [missing] (J2)
• sort::tests::stable::deterministic_i32_random_s95: ignore -> [missing] (J3)

Stage 2

• collections::btree::map::tests::test_extract_if::mutating_and_removing: [missing] -> pass (J0)
• collections::hash::set::tests::test_move_iter: [missing] -> pass (J0)
• f32::test_asinh: [missing] -> pass (J0)
• fmt::builders::debug_tuple::test_multiple: [missing] -> pass (J0)
• instant_duration_since_saturates: [missing] -> pass (J0)
• io::buffered::tests::bench_buffered_reader_small_reads: [missing] -> pass (J0)
• iter::adapters::array_chunks::test_iterator_array_chunks_try_rfold: [missing] -> pass (J0)
• iter::adapters::intersperse::test_intersperse_collect_string: [missing] -> pass (J0)
• mpsc_sync::oneshot_single_thread_try_recv_open: [missing] -> pass (J0)
• num::bignum::test_fmt: [missing] -> pass (J0)
• num::i16::test_overflows: [missing] -> pass (J0)
• num::i32::test_leading_trailing_ones: [missing] -> pass (J0)
• num::i64::test_unbounded_shl: [missing] -> pass (J0)
• num::test_try_u128u8: [missing] -> pass (J0)
• num::test_try_u32u64: [missing] -> pass (J0)
• slice::slice_index::range_len_len::index_mut_fail: [missing] -> pass (J0)
• slice::test_rchunks_exact_mut_remainder: [missing] -> pass (J0)
• slice::test_split_iterator: [missing] -> pass (J0)
• slice::test_truncate: [missing] -> pass (J0)
• str::pattern::char_searcher_short_haystack::fwd: [missing] -> pass (J0)
• str::strslice_issue_16878: [missing] -> pass (J0)
• str::test_as_bytes_fail: [missing] -> pass (J0)
• time::from_weeks_overflow: [missing] -> pass (J0)
• bit_set::tests::grow: [missing] -> pass (J1)
• check_attr::verify_passes_diagnostic_diagnostic_on_unimplemented_only_for_traits_0: [missing] -> pass (J1)
• clean::cfg::tests::test_render_short_html: [missing] -> pass (J1)
• error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_unknown_format_parameter_for_on_unimplemented_attr_4: [missing] -> pass (J1)
• errors::verify_ast_passes_item_invalid_safety_16: [missing] -> pass (J1)
• errors::verify_ast_passes_trait_object_single_bound_33: [missing] -> pass (J1)
• errors::verify_builtin_macros_asm_unsupported_operand_82: [missing] -> pass (J1)
• errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_91: [missing] -> pass (J1)
• errors::verify_builtin_macros_trace_macros_23: [missing] -> pass (J1)
• errors::verify_codegen_ssa_extract_bundled_libs_archive_member_72: [missing] -> pass (J1)
• errors::verify_const_eval_non_const_try_block_from_output_30: [missing] -> pass (J1)
• errors::verify_metadata_failed_write_error_52: [missing] -> pass (J1)
• errors::verify_mir_build_non_const_path_2: [missing] -> pass (J1)
• html::highlight::tests::test_union_highlighting: [missing] -> pass (J1)
• html::render::ordered_json::tests::escape_json_array: [missing] -> pass (J1)
• lints::verify_lint_builtin_export_name_method_18: [missing] -> pass (J1)
• lints::verify_lint_macro_expanded_macro_exports_accessed_by_absolute_paths_128: [missing] -> pass (J1)
• markdown::parse::tests::test_list_with_space: [missing] -> pass (J1)
• owned_slice::tests::try_and_fail: [missing] -> pass (J1)
• session_diagnostics::verify_attr_parsing_incorrect_repr_format_packed_expect_integer_10: [missing] -> pass (J1)
• session_diagnostics::verify_driver_impl_rlink_wrong_file_type_2: [missing] -> pass (J1)
• spec::tests::nvptx64_nvidia_cuda: [missing] -> pass (J1)
• fmt::write_u128_max: [missing] -> pass (J2)
• num::bench_i32_from_str_radix_36: [missing] -> pass (J2)
• num::bench_i64_from_str: [missing] -> pass (J2)
• num::u64::test_lots_of_isqrt: [missing] -> pass (J2)
• os::unix::net::tests::test_unix_stream_timeout_zero_duration: [missing] -> pass (J2)
• slice::sort_unstable_by_key_lexicographic: [missing] -> pass (J2)
• sort::tests::unstable::stability_string_random_d20: [missing] -> pass (J2)
• str::char_count::ru_large::case02_iter_increment: [missing] -> pass (J2)
• sort::tests::stable::observable_is_less_random_s95: [missing] -> ignore (J3)
• string::test_try_with_capacity: [missing] -> ignore (J3)

(and 16504 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
• J1: aarch64-apple, x86_64-apple-1
• J2: aarch64-apple, test-various, x86_64-apple-1
• J3: x86_64-gnu-aux

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f6b5da71ea5cc0643906e38178d54483a9bbf1bf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 5268.4s -> 1212.7s (-77.0%)
2. test-various: 4090.5s -> 2277.9s (-44.3%)
3. x86_64-gnu-aux: 6128.4s -> 4244.3s (-30.7%)
4. x86_64-apple-1: 10323.4s -> 7776.4s (-24.7%)
5. aarch64-apple: 4366.4s -> 3648.7s (-16.4%)
6. dist-x86_64-mingw: 7653.1s -> 8662.3s (13.2%)
7. dist-aarch64-apple: 5348.7s -> 4749.3s (-11.2%)
8. aarch64-gnu-debug: 4094.9s -> 4410.2s (7.7%)
9. dist-riscv64-linux: 5177.7s -> 5441.1s (5.1%)
10. dist-arm-linux: 4936.9s -> 4702.9s (-4.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (f6b5da7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.0%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.5%, 2.9%]	2
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

Results (secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.321s -> 771.902s (-0.05%)
Artifact size: 365.45 MiB -> 365.42 MiB (-0.01%)