Skip to content

Conversation

omahs
Copy link
Contributor

@omahs omahs commented May 12, 2025

Fix typos

@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not do shotgun spelling fixes like this.

  • The windows binding change is actually wrong.
  • Several changes here affect tools, that while can be josh-synced, do not justify changing them in r-l/r instead of their own repos. This increase sync conflicts just for typo fixes. This includes the clippy, rust-analyzer, and rustc-dev-guide changes.

I'm okay with accepting only the compiler/* and src/doc/rustc/* changes, but please drop all other changes.

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@omahs
Copy link
Contributor Author

omahs commented May 12, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you squash the commits into one?

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed O-windows Operating system: Windows T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 12, 2025

📌 Commit 1caaa88 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned davidtwco May 12, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2025
@bors
Copy link
Collaborator

bors commented May 13, 2025

⌛ Testing commit 1caaa88 with merge 32d2385...

@bors
Copy link
Collaborator

bors commented May 13, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 32d2385 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2025
@bors bors merged commit 32d2385 into rust-lang:master May 13, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 13, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3ae0b2e (parent) -> 32d2385 (this PR)

Test differences

Show 33150 test diffs

Stage 1

  • any::any_unsized: [missing] -> pass (J0)
  • collections::hash::map::tests::test_insert_conflicts: [missing] -> pass (J0)
  • collections::hash::set::tests::test_extract_if_pred_panic_leak: [missing] -> pass (J0)
  • condvar::wait_timeout_wake: [missing] -> pass (J0)
  • iter::adapters::step_by::test_iterator_step_by_nth_overflow: [missing] -> pass (J0)
  • iter::traits::double_ended::test_rposition: [missing] -> pass (J0)
  • mpsc::test_nested_recv_iter: [missing] -> pass (J0)
  • net::ip_addr::ipv6_from_octets: [missing] -> pass (J0)
  • num::dec2flt::decimal::check_fast_path_f32: [missing] -> pass (J0)
  • num::float_iter_sum_identity::f32_ref: [missing] -> pass (J0)
  • num::flt2dec::strategy::dragon::shortest_sanity_test: [missing] -> pass (J0)
  • num::i128::test_num: [missing] -> pass (J0)
  • num::i16::test_from_str_radix: [missing] -> pass (J0)
  • num::test_try_u8u128: [missing] -> pass (J0)
  • num::test_try_u8u8: [missing] -> pass (J0)
  • num::u16::test_swap_bytes: [missing] -> pass (J0)
  • num::u8::test_num: [missing] -> pass (J0)
  • ptr::test_as_ref: [missing] -> pass (J0)
  • rc::test_unique_rc_weak: [missing] -> pass (J0)
  • slice::split_off_first_mut_nonempty: [missing] -> pass (J0)
  • slice::test_array_chunks_nth_back: [missing] -> pass (J0)
  • slice::test_chunks_exact_iterator: [missing] -> pass (J0)
  • slice::test_iterator: [missing] -> pass (J0)
  • slice::test_slice_partition_dedup_empty: [missing] -> pass (J0)
  • str::pattern::str_searcher_empty_needle_multibyte_haystack::bwd: [missing] -> pass (J0)
  • test_unix_absolute: [missing] -> pass (J0)
  • thread::tests::test_spawn_sched_childs_on_default_sched: [missing] -> pass (J0)
  • vec_deque::test_try_fold_none: [missing] -> pass (J0)
  • ascii::short::is_ascii: [missing] -> pass (J1)
  • net::tcp::tests::test_read_with_timeout: [missing] -> pass (J1)
  • num::flt2dec::strategy::grisu::bench_big_exact_inf: [missing] -> pass (J1)
  • os::unix::net::tests::test_unix_datagram_timeout_zero_duration: [missing] -> pass (J1)
  • slice::push: [missing] -> pass (J1)
  • sort::tests::unstable::correct_f128_random_d2: [missing] -> pass (J1)
  • sort::tests::unstable::panic_observable_is_less_descending: [missing] -> pass (J1)
  • string::from_utf8_lossy_100_ascii: [missing] -> pass (J1)
  • term::terminfo::parm::tests::test_comparison_ops: [missing] -> pass (J1)
  • tests::test_should_panic_bad_message: [missing] -> pass (J1)
  • vec::bench_chain_chain_collect: [missing] -> pass (J1)
  • error::verify_middle_failed_writing_file_1: [missing] -> pass (J2)
  • errors::verify_ast_passes_extern_without_abi_61: [missing] -> pass (J2)
  • errors::verify_hir_typeck_arg_mismatch_indeterminate_17: [missing] -> pass (J2)
  • errors::verify_hir_typeck_no_associated_item_19: [missing] -> pass (J2)
  • errors::verify_incremental_ok_3: [missing] -> pass (J2)
  • errors::verify_metadata_raw_dylib_only_windows_16: [missing] -> pass (J2)
  • errors::verify_metadata_two_panic_runtimes_3: [missing] -> pass (J2)
  • errors::verify_mir_build_const_param_in_pattern_1: [missing] -> pass (J2)
  • lints::verify_lint_builtin_unsafe_extern_block_8: [missing] -> pass (J2)
  • session_diagnostics::verify_driver_impl_rlink_encoding_version_mismatch_4: [missing] -> pass (J2)
  • source_map::tests::path_prefix_remapping: [missing] -> pass (J2)
  • tests::invalid06: [missing] -> pass (J2)
  • sort::tests::unstable::panic_retain_orig_set_i32_descending: [missing] -> ignore (J3)
  • sort::tests::unstable::stability_i32_random: [missing] -> ignore (J3)

Stage 2

  • array::array_rsplit_array_ref_out_of_bounds: pass -> [missing] (J0)
  • atomic::bool_and: pass -> [missing] (J0)
  • f32::test_exp2: pass -> [missing] (J0)
  • io::tests::slice_read_exact_eof: pass -> [missing] (J0)
  • iter::adapters::fuse::test_fuse_last: pass -> [missing] (J0)
  • iter::adapters::peekable::test_peekable_non_fused: pass -> [missing] (J0)
  • iter::traits::iterator::test_iterator_advance_back_by: pass -> [missing] (J0)
  • mpsc_sync::send1: pass -> [missing] (J0)
  • mpsc_sync::stress_recv_timeout_shared: pass -> [missing] (J0)
  • nonzero::test_nonzero_uint_div: pass -> [missing] (J0)
  • num::bignum::test_ord: pass -> [missing] (J0)
  • num::ops::test_bitor_defined: pass -> [missing] (J0)
  • num::ops::test_shl_assign_defined: pass -> [missing] (J0)
  • num::test_try_i128i16: pass -> [missing] (J0)
  • rwlock::test_rw_arc_poison_ww: pass -> [missing] (J0)
  • slice::test_rchunks_nth: pass -> [missing] (J0)
  • str::test_rsplitn_char_iterator: pass -> [missing] (J0)
  • string::test_into_boxed_str: pass -> [missing] (J0)
  • vec::test_from_iter_specialization_head_tail_drop: pass -> [missing] (J0)
  • vec::test_slice_out_of_bounds_4: pass -> [missing] (J0)
  • ascii::long::is_ascii_digit: pass -> [missing] (J1)
  • btree::map::first_and_last_0_stable: pass -> [missing] (J1)
  • hash::sip::bench_long_str: pass -> [missing] (J1)
  • net::tcp::tests::multiple_connect_serial: pass -> [missing] (J1)
  • num::midpoint::midpoint_order_expectation_u8: pass -> [missing] (J1)
  • os::unix::net::tests::test_unix_stream_peek: pass -> [missing] (J1)
  • sort::tests::unstable::deterministic_cell_i32_ascending: pass -> [missing] (J1)
  • sort::tests::unstable::violate_ord_retain_orig_set_cell_i32_random: pass -> [missing] (J1)
  • stats::tests::sum_three_items: pass -> [missing] (J1)
  • vec::bench_clone_0000: pass -> [missing] (J1)
  • errors::verify_codegen_ssa_invalid_monomorphization_expected_return_type_112: pass -> [missing] (J2)
  • errors::verify_lint_unknown_tool_in_scoped_lint_0: pass -> [missing] (J2)
  • errors::verify_mir_build_lower_range_bound_must_be_less_than_upper_7: pass -> [missing] (J2)
  • errors::verify_parse_inclusive_range_match_arrow_40: pass -> [missing] (J2)
  • errors::verify_parse_unexpected_expr_in_pat_129: pass -> [missing] (J2)
  • errors::verify_passes_used_static_76: pass -> [missing] (J2)
  • lints::verify_lint_query_untracked_55: pass -> [missing] (J2)
  • mir::interpret::allocation::init_mask::tests::grow_within_unused_bits_with_overlap: pass -> [missing] (J2)
  • persist::fs::tests::test_all_except_most_recent: pass -> [missing] (J2)
  • session_diagnostics::verify_attr_parsing_multiple_item_2: pass -> [missing] (J2)
  • spec::tests::bpfel_unknown_none: pass -> [missing] (J2)
  • spec::tests::riscv32imc_unknown_nuttx_elf: pass -> [missing] (J2)
  • spec::tests::x86_64_wrs_vxworks: pass -> [missing] (J2)
  • tests::test_search_paths_tracking_hash_different_order: pass -> [missing] (J2)
  • sort::tests::stable::correct_f128_ascending: ignore -> [missing] (J3)
  • sort::tests::unstable::self_cmp_cell_i32_ascending: ignore -> [missing] (J3)
  • sort::tests::unstable::stability_i32_descending: ignore -> [missing] (J3)

(and 16504 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 32d23857f168a71bd0e77b17c0984b567461f7dc --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 1384.0s -> 5268.4s (280.7%)
  2. test-various: 2253.8s -> 4090.5s (81.5%)
  3. x86_64-gnu-aux: 4144.1s -> 6128.4s (47.9%)
  4. aarch64-apple: 3209.0s -> 4366.4s (36.1%)
  5. x86_64-apple-1: 11522.4s -> 10323.4s (-10.4%)
  6. x86_64-msvc-ext3: 8202.3s -> 7636.1s (-6.9%)
  7. i686-gnu-nopt-2: 6851.4s -> 6403.3s (-6.5%)
  8. i686-msvc-1: 9931.1s -> 9362.1s (-5.7%)
  9. dist-loongarch64-linux: 6566.2s -> 6211.6s (-5.4%)
  10. dist-x86_64-freebsd: 5079.9s -> 4805.8s (-5.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (32d2385): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

Cycles

Results (primary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.806s -> 772.321s (0.07%)
Artifact size: 365.41 MiB -> 365.45 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants