Rollup of 9 pull requests #140242
Closed
Rollup of 9 pull requests #140242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…32-msvc targets also mention the MSVC alignment issue in platform-support.md
Certain filesystems for large monorepos are slow to service individual read requests, but can service many in parallel. This change brings down the time to run a single cached test on one of those filesystems from 40s to about 8s.
To preserve CFI directives in assembly tests.
…wind-tables=yes`
And ping jieyouxu on changes.
…oli-obk mitigate MSVC alignment issue on x86-32 This implements mitigation for rust-lang#112480 by stopping to emit `align` attributes on loads and function arguments when building for a win32 MSVC target. MSVC is known to not properly align `u64` and similar types, and claiming to LLVM that everything is properly aligned increases the chance that this will cause problems. Of course, the misalignment is still a bug, but we can't fix that bug, only MSVC can. Also add an errata note to the platform support page warning users about this known problem. try-job: `i686-msvc*`
Mention average in midpoint documentations Added a mention to "average" in midpoint documentations and as well as some `#[doc(alias = "average")]`[^1]. This is done to improve the discoverability of the function. [^1]: https://docs.rs/num-integer/latest/num_integer/trait.Average.html#tymethod.average_floor
[compiletest] Parallelize test discovery Certain filesystems are slow to service individual read requests, but can service many in parallel. This change brings down the time to run a single cached test on one of those filesystems from 40s to about 8s.
…atrieb Update doc of cygwin target Some trivial updates.
…rrors Rename `compute_x` methods r? ``@lcnr`` I find the `compute_x` naming scheme to be overly confusing. It means `compute_wf_obligations_for_x_and_add_them_to_self` but shortens out all of the important parts of the actual operation being performed. `compute_x` sounds like its somehow performing `x`, maybe even returning it from the function, which is not true. I've had some newer contributors be confused by this naming scheme so I think it's good to change it to something more self-evident Some misc drive by niceties while I was here too.
…les, r=bjorn3 minicore: Have `//@ add-core-stubs` also imply `-Cforce-unwind-tables=yes` To preserve CFI directives in assembly tests, as `//@ add-core-stubs` already imply `-C panic=abort`. This is a blocker for rust-lang#140037 (comment). cc ``@RalfJung`` r? ``@bjorn3``
…youxu triagebot: label minicore changes w/ `A-test-infra-minicore` and ping jieyouxu on changes Just routine triagebot labelling/mentioning changes. r? ``@ghost``
Remove comment about handling non-global where bounds with corresponding projection This comment is no longer relevant since we only assemble rigid projections if no param-env candidates hold. Also remove a stray comment from the old solver. r? lcnr
…covery, r=jieyouxu Revert overzealous parse recovery for single colons in paths Basically manually reverts rust-lang#136808, cc `@chenyukang` `@estebank.` Reopens rust-lang#129273. Fixes [after beta backport] rust-lang#140227.
rustbot
added
A-compiletest
rustbot
added
WG-trait-system-refactor
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
compute_xmethods #140186 (Renamecompute_xmethods)//@ add-core-stubsalso imply-Cforce-unwind-tables=yes#140194 (minicore: Have//@ add-core-stubsalso imply-Cforce-unwind-tables=yes)A-test-infra-minicoreand ping jieyouxu on changes #140195 (triagebot: label minicore changes w/A-test-infra-minicoreand ping jieyouxu on changes)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup