Skip to content

Add try_type_param and param_at to avoid array out of bound #138219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add try_type_param and param_at to avoid array out of bound #138219

wants to merge 1 commit into from

Conversation

xizheyin
Copy link
Member

@xizheyin xizheyin commented Mar 8, 2025

Fixes #137865

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Mar 8, 2025

r? types

@rustbot rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Mar 8, 2025
@rustbot rustbot assigned BoxyUwU and unassigned jieyouxu Mar 8, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Mar 8, 2025 •
edited
Loading

This is almost certainly not the right fix. For example, I think I literally removed functions like this from Generics in the past. This should be dealt with earlier in the compiler.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025
@compiler-errors
Copy link
Member

I put up an alternative fix in #138256

@xizheyin
Copy link
Member Author

xizheyin commented Mar 9, 2025

Thanks for pointing this out, very insightful revision. @compiler-errors

@xizheyin xizheyin closed this Mar 9, 2025
@compiler-errors compiler-errors mentioned this pull request Mar 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: generics: index out of bounds
5 participants
@xizheyin @rustbot @jieyouxu @compiler-errors @BoxyUwU