Skip to content

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 17, 2024

Fixes the wasm64 build failure reported at rust-lang/llvm-project#180.

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2024
@cuviper
Copy link
Member

cuviper commented Dec 17, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Dec 17, 2024

📌 Commit 1d4530b has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2024
@jieyouxu
Copy link
Member

@bors p=5 (rollup scheduling)

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
Update to LLVM 19.1.6

Fixes the wasm64 build failure reported at rust-lang/llvm-project#180.
@bors
Copy link
Collaborator

bors commented Dec 18, 2024

⌛ Testing commit 1d4530b with merge b79084f...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Dec 18, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2024
@dianqk
Copy link
Member

dianqk commented Dec 18, 2024

@bors retry
curl: (56) Recv failure: Connection reset by peer

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2024
@bors
Copy link
Collaborator

bors commented Dec 18, 2024

⌛ Testing commit 1d4530b with merge 057bdb3...

@bors
Copy link
Collaborator

bors commented Dec 18, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 057bdb3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2024
@bors bors merged commit 057bdb3 into rust-lang:master Dec 18, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 18, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (057bdb3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.4%, secondary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.888s -> 769.67s (-0.29%)
Artifact size: 330.28 MiB -> 330.31 MiB (0.01%)

@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants