Skip to content

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 16, 2024

r? @ghost

Veykril and others added 30 commits December 11, 2024 09:34
Previously all lints were assumed to be `#[warn]`, and we had a hand-coded list of `#[allow]` exceptions. Now the severity is autogenerated from rustdoc output.

Also support lints that change status between editions, and the `warnings` lint group.
…everity

Properly handle different defaults for severity of lints
…le_with_no_snippet

fix: Generate implementation with items even if snippet text edit is disabled
fix: copied proc-macros not being cleaned up on exit
fix: Fix sourceroot construction for virtual manifests
internal: Only parse the object file once in proc-macro-srv
feat: Add an assist to extract an expression into a constant
internal: Drop proc-macro server support for ~1.66.0 and older toolchains
Corrected the spelling of "defererence" to "dereference" in the error message that informs users about invalid casting requirements.
Fix typo in error message for invalid casting
fix: Panic when displaying generic params with defaults, again
internal: Implement `naked_asm!` builtin
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@lnicola
Copy link
Member Author

lnicola commented Dec 16, 2024

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Dec 16, 2024

📌 Commit 5c6bae0 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
@bors
Copy link
Collaborator

bors commented Dec 16, 2024

⌛ Testing commit 5c6bae0 with merge b840f6b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2024
Subtree update of `rust-analyzer`

r? `@ghost`
@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  DATADOG_SITE: datadoghq.com
  DATADOG_API_KEY: ***
  DD_GITHUB_JOB_NAME: auto - dist-various-2
##[endgroup]
npm error code ECONNRESET
npm error errno ECONNRESET
npm error network Invalid response body while trying to fetch https://registry.npmjs.org/@datadog%2fdatadog-ci: aborted
npm error network This is a problem related to network connectivity.
npm error network In most cases you are behind a proxy or have bad network settings.
npm error network
npm error network If you are behind a proxy, please make sure that the
npm error network 'proxy' config is set properly.  See: 'npm help config'
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-16T12_10_52_605Z-debug-0.log
##[error]Process completed with exit code 1.

@bors
Copy link
Collaborator

bors commented Dec 16, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024
@lnicola
Copy link
Member Author

lnicola commented Dec 16, 2024

@bors retry network error?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
@bors
Copy link
Collaborator

bors commented Dec 16, 2024

⌛ Testing commit 5c6bae0 with merge 83ab648...

@bors
Copy link
Collaborator

bors commented Dec 16, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 83ab648 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2024
@bors bors merged commit 83ab648 into rust-lang:master Dec 16, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 16, 2024
@lnicola lnicola deleted the sync-from-ra branch December 16, 2024 16:01
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (83ab648): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.7%, secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.216s -> 770.694s (0.06%)
Artifact size: 332.90 MiB -> 332.93 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.