rustdoc: use the correct span for doctests #130582
Merged
+41
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
S-waiting-on-review
notriddle
commented
Sep 19, 2024
| running 3 tests | ||
| test $DIR/doctest-output.rs - (line 8) ... ok | ||
| test $DIR/doctest-output.rs - ExpandedStruct (line 24) ... ok | ||
| test $DIR/doctest-output.rs - ExpandedStruct (line 25) ... ok |
There was a problem hiding this comment.
Line 25 is here, and this seems fine.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
Sep 19, 2024
|
Ah you forgot to |
notriddle
force-pushed
the
notriddle/doctest-span
branch
from
1870efb to
65e432d
Compare
|
@GuillaumeGomez Yes, I did... |
|
Happens to the best of us. 😉 r=me once CI pass. 👍 |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#130485 (Do not expect infer/bound/placeholder/error in v0 symbol mangling) - rust-lang#130567 (Register tool docs for compiletest) - rust-lang#130582 (rustdoc: use the correct span for doctests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
Rollup merge of rust-lang#130582 - notriddle:notriddle/doctest-span, r=GuillaumeGomez rustdoc: use the correct span for doctests Fixes rust-lang#130470
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130470