Skip to content

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented May 7, 2024

In the {integer}::from_str_radix function, the radix check is labeled as cold and inline(never), along with its corresponding panic. It probably was intended to apply these attributes only to the panic function.

@rustbot
Copy link
Collaborator

rustbot commented May 7, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 7, 2024
@Amanieu
Copy link
Member

Amanieu commented May 9, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented May 9, 2024

📌 Commit eac37b6 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2024
@bors
Copy link
Collaborator

bors commented May 10, 2024

⌛ Testing commit eac37b6 with merge cf77474...

@bors
Copy link
Collaborator

bors commented May 10, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing cf77474 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 10, 2024
@bors bors merged commit cf77474 into rust-lang:master May 10, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 10, 2024
@DaniPopes DaniPopes deleted the from-str-radix-panic branch May 10, 2024 14:17
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cf77474): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.435s -> 676.035s (0.24%)
Artifact size: 315.80 MiB -> 315.80 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants