Skip to content

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 6, 2024

so as to avoid an infinite stack cycle

fixes #124805
r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 6, 2024
.at(&obligation.cause, obligation.param_env)
.eq(
DefineOpaqueTypes::No,
DefineOpaqueTypes::Yes,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao wait

@@ -0,0 +1,8 @@
//@ compile-flags: -Znext-solver=coherence
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ICEs on -Znext-solver, could add a separate revision I guess.

@lcnr
Copy link
Contributor

lcnr commented May 6, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 6, 2024

📌 Commit 116f95b has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124520 (Document that `create_dir_all` calls `mkdir`/`CreateDirW` multiple times)
 - rust-lang#124724 (Prefer lower vtable candidates in select in new solver)
 - rust-lang#124771 (Don't consider candidates with no failing where clauses when refining obligation causes in new solver)
 - rust-lang#124808 (Use `super_fold` in `RegionsToStatic` visitor)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ad73b16 into rust-lang:master May 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2024
Rollup merge of rust-lang#124808 - compiler-errors:super, r=lcnr

Use `super_fold` in `RegionsToStatic` visitor

so as to avoid an infinite stack cycle

fixes rust-lang#124805
r? lcnr
@rustbot rustbot added this to the 1.80.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coherence: stack overflow
4 participants