Fixup parsing of rustc_never_type_options attribute
#123320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy paste error strike again..
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Apr 1, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 1, 2024
…ons, r=compiler-errors Fixup parsing of `rustc_never_type_options` attribute rust-lang#122843 had a copy paste error, which I did not caught when testing. r? `@compiler-errors`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 1, 2024
…ons, r=compiler-errors Fixup parsing of `rustc_never_type_options` attribute rust-lang#122843 had a copy paste error, which I did not caught when testing. r? ``@compiler-errors``
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Apr 1, 2024
…ons, r=compiler-errors Fixup parsing of `rustc_never_type_options` attribute rust-lang#122843 had a copy paste error, which I did not caught when testing. r? ```@compiler-errors```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2024
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#123320 (Fixup parsing of `rustc_never_type_options` attribute) - rust-lang#123323 (std::thread: set_name change for solaris/illumos.) - rust-lang#123327 (Update `ParamEnv` docs) r? `@ghost` `@rustbot` modify labels: rollup
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1684a75): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 666.866s -> 668.149s (0.19%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122843 had a copy paste error, which I did not caught when testing.
r? @compiler-errors