Skip to content

Subtree sync for rustc_codegen_cranelift #118279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 25, 2023
Merged

Subtree sync for rustc_codegen_cranelift #118279

merged 21 commits into from
Nov 25, 2023

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 25, 2023

The main highlights this time are implementing a bunch of new vendor intrinsics and fixing some existing ones. And fixing polymorphization for coroutines.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

Mark-Simulacrum and others added 21 commits November 15, 2023 21:45
@Mark-Simulacrum
Add check-cfg to cranelift
497c17a
@bjorn3
Merge commit 'def04540a4e2541b995195c752c751295606a388' into sync_cg_…
dfc669b 
…clif-2023-11-16
@bjorn3
Merge branch 'sync_from_rust'
db12abf
@bjorn3
check-cfg needs -Zunstable-options
97ca520
@bjorn3
Update Cranelift to 0.102
cd7218a
@bjorn3
Fix _mm_sad_epu8 implementation
a5fcfad 
Fixes rust-lang/rustc_codegen_cranelift#1426
@bjorn3
Fix fn_sig_for_fn_abi and the coroutine transform for generators
4ae6586 
There were three issues previously:
* The self argument was pinned, despite Iterator::next taking an
  unpinned mutable reference.
* A resume argument was passed, despite Iterator::next not having one.
* The return value was CoroutineState<Item, ()> rather than Option<Item>

While these things just so happened to work with the LLVM backend,
cg_clif does much stricter checks when trying to assign a value to a
place. In addition it can't handle the mismatch between the amount of
arguments specified by the FnAbi and the FnSig.
@bjorn3
Allow function pointers in CValue::const_val
430ab4e 
Fixes rust-lang/rustc_codegen_cranelift#1430
@bjorn3
Fix polymorphization for coroutines
9c95819 
Fixes rust-lang/rustc_codegen_cranelift#1429
@bjorn3
Implement _mm_cmpestri and _mm_cmpestrm using inline asm
3ec8d7a
@bjorn3
Implement _mm_cvttps_epi32
705031d
@bjorn3
Implement *fmaddsub_p*, *fmsubadd_p* and *fnmadd_p* vendor intrinsics
65da671
@bjorn3
Implement _mm256_zeroupper vendor intrinsic
c8729e9
@bjorn3
Implement the float part of the gather family vendor intrinsics
d5a7ae7
@bjorn3
Implement the int part of the gather family vendor intrinsics
3b49b9e
@bjorn3
Fix incorrect implementation of several vendor intrinsics
e6e2f00
@bjorn3
Sync from rust 37b2813
85c7081
@bjorn3
Rustup to rustc 1.76.0-nightly (37b2813 2023-11-24)
da3782a
@bjorn3
Re-enable rustc test that was disabled due to a rustc bug
86fc533
@bjorn3
Merge pull request rust-lang#1431 from rust-lang/even_more_simd_intri…
710c679 
…nsics

Implement another batch of vendor intrinsics
@bjorn3
Merge commit '710c67909d034e1c663174a016ca82b95c2d6c12' into sync_cg_…
aa51a27 
…clif-2023-11-25
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2023

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@rustbot rustbot added A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend labels Nov 25, 2023
@bjorn3 bjorn3 removed the has-merge-commits PR has merge commits, merge with caution. label Nov 25, 2023
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 25, 2023

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Nov 25, 2023

📌 Commit aa51a27 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2023
@bors
Copy link
Collaborator

bors commented Nov 25, 2023

⌛ Testing commit aa51a27 with merge 3166210...

@bors
Copy link
Collaborator

bors commented Nov 25, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 3166210 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2023
@bors bors merged commit 3166210 into rust-lang:master Nov 25, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3166210): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.6% [-0.6%, -0.6%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.5% [1.5%, 1.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.5% [1.5%, 1.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.41s -> 674.339s (-0.16%)
Artifact size: 313.30 MiB -> 313.28 MiB (-0.01%)

@bjorn3 bjorn3 deleted the sync_cg_clif-2023-11-25 branch November 25, 2023 17:22
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Dec 19, 2023
@bors
Auto merge of rust-lang#118279 - bjorn3:sync_cg_clif-2023-11-25, r=bj…
400cd47 
…orn3

Subtree sync for rustc_codegen_cranelift

The main highlights this time are implementing a bunch of new vendor intrinsics and fixing some existing ones. And fixing polymorphization for coroutines.

r? `@ghost`

`@rustbot` label +A-codegen +A-cranelift +T-compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rustbot @bors @rust-timer @Mark-Simulacrum