Skip to content

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Nov 10, 2023

Previously we accepted CouroutineWitness as unreachable! but rust-lang/project-stable-mir#50 shows it is indeed reachable, this pr fixes that and covers CouroutineWitness

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

@ouz-a
Copy link
Contributor Author

ouz-a commented Nov 14, 2023

r? @celinval

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2023

Failed to set assignee to celinval: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@celinval
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 14, 2023

📌 Commit 6812f64 has been approved by celinval

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2023
@bors
Copy link
Collaborator

bors commented Nov 14, 2023

⌛ Testing commit 6812f64 with merge d97bb19...

@bors
Copy link
Collaborator

bors commented Nov 14, 2023

☀️ Test successful - checks-actions
Approved by: celinval
Pushing d97bb19 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 14, 2023
@bors bors merged commit d97bb19 into rust-lang:master Nov 14, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 14, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d97bb19): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.8%, 0.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.599s -> 673.271s (-0.20%)
Artifact size: 311.12 MiB -> 311.10 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants