Skip to content

Conversation

davidzr
Copy link

@davidzr davidzr commented Oct 21, 2023

Fixes #116977

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2023
@fmease
Copy link
Member

fmease commented Oct 21, 2023

Thanks for your PR! Unfortunately, #117026 was opened 5 minutes earlier and has already been approved.
I hope this doesn't discourage you from contributing in the future though!
Always happy to see more people working on Rust!

While it's not strictly necessary to do so, you can claim an issue by writing @rustbot claim to signal to others that you plan on working on it.

Closing in favor of #117026.

@fmease fmease closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Link to Ayu theme in The rustdoc book, Section 4.1

4 participants