Skip to content

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jul 17, 2023

r? @ghost

bors and others added 30 commits June 23, 2023 18:01
Upgrade to indexmap v2

No code changes required.
Fix some unsizing problems in mir
…r=Veykril

Add the comment why `HasSource::source()` returns `Option`

Fix rust-lang/rust-analyzer#15088
…libs, r=lnicola

autopublish: Rename crates after removing libs from workspace
- don't take `&self` as receiver for `Copy` types
- simplify `hir::Module::nearest_non_block_module()`
- style changes for consistency
alibektas and others added 16 commits July 15, 2023 19:04
Handle TyAlias in projected_ty

First of all I still have no idea how MIR works but rust-lang#15143 has been an issue that constantly made RA crash so I have been looking for a way to make RA stop panicking. I have zero claims that what I want to merge has any sense or is correct 😄  but there isn't any more panicking. Even if it is wrong may this be at least a step towards resolving this issue.
As is customary this PR fixes rust-lang#15143
minor: Bump rust-version to 1.70 and use the workspace one in xtask

CC rust-lang/rust-analyzer#15279
Fixed typo in documentation comment
Update flags.rs

Fixed typo in documentation comment
…, r=lnicola

Fix rust-analzyer ssr help message

It's missing a `>`, so

```
> rust-analyzer ssr '''$a.foo($b) ==> bar($a, $b)'''
can't parse `rule`, Parse error: Cannot find delimiter `==>>`
```

happens.
rust-lang#113695 makes the dylib metadata uncompressed for perf
reasons. This commit allows reading both the current compressed and
future uncompressed dylib metadata.
…=lnicola

Support reading uncompressed proc macro metadata

rust-lang#113695 makes the dylib metadata uncompressed for perf reasons. This commit allows reading both the current compressed and future uncompressed dylib metadata.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2023

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

@lnicola
Copy link
Member Author

lnicola commented Jul 17, 2023

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit d35f6c6 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2023
@bors
Copy link
Collaborator

bors commented Jul 17, 2023

⌛ Testing commit d35f6c6 with merge b3c7a7e...

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing b3c7a7e to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Jul 17, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing b3c7a7e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 17, 2023
@bors bors merged commit b3c7a7e into rust-lang:master Jul 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 17, 2023
@lnicola lnicola deleted the sync-from-ra branch July 17, 2023 15:49
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b3c7a7e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.6%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
5.2% [5.2%, 5.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.973s -> 656.058s (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.