Skip to content

rustdoc: Note in a type's layout/size if it is uninhabited #108734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

rustdoc: Note in a type's layout/size if it is uninhabited #108734

merged 1 commit into from
Mar 5, 2023

Conversation

clubby789
Copy link
Contributor

Closes #87008

image

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 4, 2023
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 4, 2023

📌 Commit 7520155 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2023
@matthiaskrgr
Rollup merge of rust-lang#108734 - clubby789:rustdoc-layout-uninhabit…
f2ae034 
…ed, r=GuillaumeGomez

rustdoc: Note in a type's layout/size if it is uninhabited

Closes rust-lang#87008

![image](https://user-images.githubusercontent.com/13556931/222900244-8e326d51-8d3b-4700-a935-96830179e2e9.png)
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 4, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2023
@bors
Auto merge of rust-lang#108747 - matthiaskrgr:rollup-wfc7fx4, r=matth…
bb18388 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108627 (Properly colorize multi-part suggestions in the same line)
 - rust-lang#108632 (Omit unchanged options from config.toml in `configure.py`)
 - rust-lang#108715 (Remove unclosed_delims from parser)
 - rust-lang#108723 (rustdoc: function signature search with traits in `where` clause)
 - rust-lang#108724 (field is not used outside the crate)
 - rust-lang#108734 (rustdoc: Note in a type's layout/size if it is uninhabited)
 - rust-lang#108736 (Remove `allow(potential_query_instability)` from `ast_passes`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 99fad38 into rust-lang:master Mar 5, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

Rustdoc: size layout should show "uninhabited" for empty enums, not 0

4 participants

@clubby789 @rustbot @GuillaumeGomez @bors