Skip to content

Fix unintentional UB in SIMD tests #107973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix unintentional UB in SIMD tests #107973

merged 1 commit into from
Feb 13, 2023

Conversation

saethlin
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2023
workingjubilee
workingjubilee reviewed Feb 13, 2023
View reviewed changes
@workingjubilee
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 13, 2023

📌 Commit 9c4696b has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
@workingjubilee
Copy link
Member

actually should make sure.
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 13, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Feb 13, 2023

📌 Commit 9c4696b has been approved by workingjubilee

It is now in the queue for this repository.

@Dylan-DPC Dylan-DPC mentioned this pull request Feb 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
@bors
Auto merge of rust-lang#107980 - Dylan-DPC:rollup-u4b19bl, r=Dylan-DPC
2008188 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#107654 (reword descriptions of the deprecated int modules)
 - rust-lang#107915 (Add `array::map` benchmarks)
 - rust-lang#107961 (Avoid copy-pasting the `ilog` panic string in a bunch of places)
 - rust-lang#107962 (Add a doc note about why `Chain` is not `ExactSizeIterator`)
 - rust-lang#107966 (Update browser-ui-test version to 0.14.3)
 - rust-lang#107970 (Hermit: Remove floor symbol)
 - rust-lang#107973 (Fix unintentional UB in SIMD tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4bf5808 into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@saethlin saethlin deleted the fix-simd-test-ub branch March 15, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebzulawski calebzulawski calebzulawski approved these changes

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@workingjubilee workingjubilee

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

5 participants

@saethlin @workingjubilee @bors @calebzulawski @rustbot