Rollup of 8 pull requests #107341

JohnTitor · 2023-01-27T02:42:03Z

Successful merges:

update stdarch #105784 (update stdarch)
core: Support variety of atomic widths in width-agnostic functions #106856 (core: Support variety of atomic widths in width-agnostic functions)
Detect references to non-existant messages in Fluent resources #107096 (Detect references to non-existant messages in Fluent resources)
rustdoc: make item links consistently use title="{shortty} {path}" #107242 (rustdoc: make item links consistently use title="{shortty} {path}")
Use new solver during selection #107279 (Use new solver during selection)
rustdoc: use smarter encoding for playground URL #107284 (rustdoc: use smarter encoding for playground URL)
rustdoc: Stop using HirIds #107325 (rustdoc: Stop using HirIds)
rustdoc: remove mostly-unused CSS classes import-item and module-item #107336 (rustdoc: remove mostly-unused CSS classes import-item and module-item)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This will allow using miri on simd instructions rust-lang/stdarch#1347 (comment)

The ordering in item tables was flipped in 3030cbe, making it inconsistent with the ordering in method signatures. Compare these: https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/render/print_item.rs#L455-L459 https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/format.rs#L903-L908

Atomic operations for different widths (8-bit, 16-bit, 32-bit etc.) are guarded by `target_has_atomic = "value"` symbol (i.e. `target_has_atomic = "8"`) (and the other derivatives), but before this change, there was no width-agnostic symbol indicating a general availability of atomic operations. This change introduces: * `target_has_atomic_load_store` symbol when atomics for any integer width are supported by the target. * `target_has_atomic` symbol when also CAS is supported. Fixes rust-lang#106845 Signed-off-by: Michal Rostecki <[email protected]>

Before this change, the following functions and macros were annotated with `#[cfg(target_has_atomic = "8")]` or `#[cfg(target_has_atomic_load_store = "8")]`: * `atomic_int` * `strongest_failure_ordering` * `atomic_swap` * `atomic_add` * `atomic_sub` * `atomic_compare_exchange` * `atomic_compare_exchange_weak` * `atomic_and` * `atomic_nand` * `atomic_or` * `atomic_xor` * `atomic_max` * `atomic_min` * `atomic_umax` * `atomic_umin` However, none of those functions and macros actually depend on 8-bit width and they are needed for all atomic widths (16-bit, 32-bit, 64-bit etc.). Some targets might not support 8-bit atomics (i.e. BPF, if we would enable atomic CAS for it). This change fixes that by removing the `"8"` argument from annotations, which results in accepting the whole variety of widths. Fixes rust-lang#106845 Fixes rust-lang#106795 Signed-off-by: Michal Rostecki <[email protected]>

Use `LocalDefId`s instead

The old way would compress okay with DEFLATE, but this version makes uncompressed docs smaller, which matters for memory usage and stuff like `cargo doc`. Try it out: <https://play.rust-lang.org/?code=fn+main()+{%0Alet+mut+v+=+Vec::new();%0Av.push(1+/+1);%0Aprintln!(%22{}%22,+v[0]);%0A}> In local testing, this change shrinks sample pages by anywhere between 4.0% and 0.031% $ du -b after.dir/std/vec/struct.Vec.html before.dir/std/vec/struct.Vec.html 759235 after.dir/std/vec/struct.Vec.html 781842 before.dir/std/vec/struct.Vec.html 100*((759235-781842)/781842)=-2.8 $ du -b after.dir/std/num/struct.Wrapping.html before.dir/std/num/struct.Wrapping.html 3194173 after.dir/std/num/struct.Wrapping.html 3204351 before.dir/std/num/struct.Wrapping.html 100*((3194173-3204351)/3204351)=-0.031 $ du -b after.dir/std/keyword.match.html before.dir/std/keyword.match.html 8151 after.dir/std/keyword.match.html 8495 before.dir/std/keyword.match.html 100*((8151-8495)/8495)=-4.0 Gzipped tarball sizes seem shrunk, but not by much. du -s before.tar.gz after.tar.gz 69600 before.tar.gz 69480 after.tar.gz 100*((69480-69600)/69600)=-0.17

update stdarch This will allow using miri on simd instructions rust-lang/stdarch#1347 (comment)

… r=joshtriplett core: Support variety of atomic widths in width-agnostic functions Before this change, the following functions and macros were annotated with `#[cfg(target_has_atomic = "8")]` or `#[cfg(target_has_atomic_load_store = "8")]`: * `atomic_int` * `strongest_failure_ordering` * `atomic_swap` * `atomic_add` * `atomic_sub` * `atomic_compare_exchange` * `atomic_compare_exchange_weak` * `atomic_and` * `atomic_nand` * `atomic_or` * `atomic_xor` * `atomic_max` * `atomic_min` * `atomic_umax` * `atomic_umin` However, none of those functions and macros actually depend on 8-bit width and they are needed for all atomic widths (16-bit, 32-bit, 64-bit etc.). Some targets might not support 8-bit atomics (i.e. BPF, if we would enable atomic CAS for it). This change fixes that by removing the `"8"` argument from annotations, which results in accepting the whole variety of widths. Fixes rust-lang#106845 Fixes rust-lang#106795 Signed-off-by: Michal Rostecki <[email protected]>

…=compiler-errors Detect references to non-existant messages in Fluent resources Should help with cases like rust-lang#107091, where `{variable}` (a message reference) is accidentally typed, rather than `{$variable}` (a variable reference) `@rustbot` label +A-translation

…, r=GuillaumeGomez rustdoc: make item links consistently use `title="{shortty} {path}"` The ordering in item tables was flipped in 3030cbe, making it inconsistent with the ordering in method signatures. Compare these (before this PR is merged): https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/render/print_item.rs#L455-L459 https://github.com/rust-lang/rust/blob/c8e6a9e8b6251bbc8276cb78cabe1998deecbed7/src/librustdoc/html/format.rs#L903-L908

…e, r=lcnr Use new solver during selection r? `@lcnr`

rustdoc: use smarter encoding for playground URL The old way would compress okay with DEFLATE, but this version makes uncompressed docs smaller, which matters for memory usage and stuff like `cargo doc`. Try it out: <https://play.rust-lang.org/?code=fn+main()+{%0Alet+mut+v+=+Vec::new();%0Av.push(1+/+1);%0Aprintln!(%22{}%22,+v[0]);%0A}> In local testing, this change shrinks sample pages by anywhere between 4.0% and 0.031% $ du -b after.dir/std/vec/struct.Vec.html before.dir/std/vec/struct.Vec.html 759235 after.dir/std/vec/struct.Vec.html 781842 before.dir/std/vec/struct.Vec.html 100*((759235-781842)/781842)=-2.8 $ du -b after.dir/std/num/struct.Wrapping.html before.dir/std/num/struct.Wrapping.html 3194173 after.dir/std/num/struct.Wrapping.html 3204351 before.dir/std/num/struct.Wrapping.html 100*((3194173-3204351)/3204351)=-0.031 $ du -b after.dir/std/keyword.match.html before.dir/std/keyword.match.html 8151 after.dir/std/keyword.match.html 8495 before.dir/std/keyword.match.html 100*((8151-8495)/8495)=-4.0 Gzipped tarball sizes seem shrunk, but not by much. du -s before.tar.gz after.tar.gz 69600 before.tar.gz 69480 after.tar.gz 100*((69480-69600)/69600)=-0.17

…omez rustdoc: Stop using `HirId`s Use `LocalDefId`s instead. Rustdoc doesn't work with item bodies, so it almost never needs fine-grained HIR IDs.

…dule-item, r=GuillaumeGomez rustdoc: remove mostly-unused CSS classes `import-item` and `module-item`

JohnTitor · 2023-01-27T02:42:23Z

@bors r+ rollup=never p=8

bors · 2023-01-27T02:42:25Z

📌 Commit 9add2a8 has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2023-01-27T03:12:09Z

⌛ Testing commit 9add2a8 with merge 2308a8b17e638257cc9cbbf56e586f5594a11c6b...

bors · 2023-01-27T03:25:09Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-01-27T03:25:11Z

The job dist-mipsel-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] fluent_bundle test:false 1.416
error: using `iter` can result in unstable query results
   --> compiler/rustc_macros/src/diagnostics/fluent.rs:279:43
    |
279 |         for (&mref, &name) in messagerefs.iter() {
    |
    |
    = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale
    = note: `-D rustc::potential-query-instability` implied by `-D warnings`
[RUSTC-TIMING] rustc_macros test:false 0.953
error: could not compile `rustc_macros` due to previous error
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] rustc_macros test:false 2.528

yanns and others added 20 commits December 29, 2022 11:22

update stdarch

a538723

This will allow using miri on simd instructions rust-lang/stdarch#1347 (comment)

remove avx512 prefix for gfni, vaes and vpclmulqdq

a499862

fix alphabetical sort

2e8162a

Detect references to non-existant messages in Fluent resources

fc86e7a

Fix some Fluent typos

89b1f39

rustdoc: Stop using HirIds

347fa7a

Use `LocalDefId`s instead

rustdoc: remove mostly-unused CSS classes import/module-item

97f8189

Use new solver during selection

9b5a2a4

Rollup merge of rust-lang#105784 - yanns:update_stdarch, r=Amanieu

a5a8b48

update stdarch This will allow using miri on simd instructions rust-lang/stdarch#1347 (comment)

Rollup merge of rust-lang#107279 - compiler-errors:new-solver-evaluat…

d29244f

…e, r=lcnr Use new solver during selection r? `@lcnr`

Rollup merge of rust-lang#107325 - petrochenkov:hiddoc2, r=GuillaumeG…

eee6648

…omez rustdoc: Stop using `HirId`s Use `LocalDefId`s instead. Rustdoc doesn't work with item bodies, so it almost never needs fine-grained HIR IDs.

Rollup merge of rust-lang#107336 - notriddle:notriddle/import-item-mo…

9add2a8

…dule-item, r=GuillaumeGomez rustdoc: remove mostly-unused CSS classes `import-item` and `module-item`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2023

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 27, 2023

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2023

JohnTitor mentioned this pull request Jan 27, 2023

Detect references to non-existant messages in Fluent resources #107096

Merged

JohnTitor closed this Jan 27, 2023

JohnTitor deleted the rollup-dz8v5tp branch January 27, 2023 03:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests #107341

Rollup of 8 pull requests #107341

Uh oh!

JohnTitor commented Jan 27, 2023

Uh oh!

JohnTitor commented Jan 27, 2023

Uh oh!

bors commented Jan 27, 2023

Uh oh!

bors commented Jan 27, 2023

Uh oh!

bors commented Jan 27, 2023

Uh oh!

rust-log-analyzer commented Jan 27, 2023

Uh oh!

Uh oh!

Rollup of 8 pull requests #107341

Rollup of 8 pull requests #107341

Uh oh!

Conversation

JohnTitor commented Jan 27, 2023

Uh oh!

JohnTitor commented Jan 27, 2023

Uh oh!

bors commented Jan 27, 2023

Uh oh!

bors commented Jan 27, 2023

Uh oh!

bors commented Jan 27, 2023

Uh oh!

rust-log-analyzer commented Jan 27, 2023

Uh oh!

Uh oh!