Skip to content

Conversation

LeSeulArtichaut
Copy link
Contributor

Fixes #106126, alternative to #106127.
r? @ghost for now.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 26, 2022
@compiler-errors
Copy link
Member

r=me with FIXME stating that not trimming the path is non-ideal

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jan 2, 2023

✌️ @LeSeulArtichaut can now approve this pull request

@LeSeulArtichaut LeSeulArtichaut force-pushed the 106126-thir-unsafeck-good-path-bug-2 branch from 024a9a3 to 2a7d559 Compare January 2, 2023 23:29
@LeSeulArtichaut
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jan 2, 2023

📌 Commit 2a7d559 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2023
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104748 (Ensure `lld` is supported with `download-ci-llvm`)
 - rust-lang#105541 (Simplify some iterator combinators)
 - rust-lang#106045 (default OOM handler: use non-unwinding panic, to match std handler)
 - rust-lang#106157 (Don't trim path for `unsafe_op_in_unsafe_fn` lints)
 - rust-lang#106353 (Reduce spans for `unsafe impl` errors)
 - rust-lang#106381 (Jsondoclint: Add `--verbose` and `--json-output` options)
 - rust-lang#106411 (rustdoc: remove legacy font-feature-settings CSS)
 - rust-lang#106414 (Add cuviper to the review rotation for libs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dc5247b into rust-lang:master Jan 4, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 4, 2023
@LeSeulArtichaut LeSeulArtichaut deleted the 106126-thir-unsafeck-good-path-bug-2 branch January 4, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: 'trimmed_def_paths constructed but no error emitted' in THIR unsafety checker
4 participants