Skip to content

rustdoc: Do not expect doc(primitive) modules to always exist #103120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

rustdoc: Do not expect doc(primitive) modules to always exist #103120

merged 2 commits into from
Oct 17, 2022

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Oct 16, 2022 •
edited
Loading

The second commit fixes one more ICE by processing impls in crates loaded through the "load all --externs" hack.

Fixes #96288
Fixes #103028

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 16, 2022
@rust-highfive
Copy link
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
@petrochenkov petrochenkov mentioned this pull request Oct 16, 2022
Closed
@petrochenkov
rustdoc: Process extern impls in all loaded crates
dd7411d 
including those loaded through hacks.
@petrochenkov petrochenkov mentioned this pull request Oct 16, 2022
Closed
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@petrochenkov
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Oct 16, 2022

📌 Commit dd7411d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2022
@bors
Auto merge of rust-lang#103125 - matthiaskrgr:rollup-82xttcl, r=matth…
a501e66 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#103087 (Documentation BTreeMap::append's behavior for already existing keys)
 - rust-lang#103089 (Mark derived StructuralEq as automatically derived.)
 - rust-lang#103102 (Clarify the possible return values of `len_utf16`)
 - rust-lang#103109 (PhantomData: inline a macro that is used only once)
 - rust-lang#103120 (rustdoc: Do not expect `doc(primitive)` modules to always exist)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db30a25 into rust-lang:master Oct 17, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 17, 2022
@petrochenkov petrochenkov deleted the docice branch February 22, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jsha jsha

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

Running cargo doc fails to generate with thread panic rustdoc: unwrap of none: src/librustdoc/passes/collect_intra_doc_links.rs

6 participants

@petrochenkov @rust-highfive @GuillaumeGomez @bors @jsha @rustbot