filter out hidden comments from reports #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated comments are filtered from reports, so we don't see e.g. #270 (comment) from this goal report.
However, other comments such as #270 (comment) were hidden as outdated but will still be present in the report, as can currently be seen here for the SVE goal.
This PR filters out the GH comments marked as hidden in general, so that the goal owners or person generating the monthly report can remove the comments that were taken care of already, or outdated or unrelated comments from the reports, instead of how we've been doing it usually, manually deleting them from the generated markdown. This is useful now with the new idea of the reports and blog posts being live documents where this strategy doesn't work anymore.