Extend unnecessary_lazy_eval to cover bool::then -> bool::then_some
#9099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This is WIP because I haven't managed to get the change to actually fire on the test case; I would appreciate advice on what I'm missing. |
Serial-ATA
reviewed
Jul 3, 2022
|
This should probably have a MSRV check for 1.62. |
joshtriplett
force-pushed
the
unnecessary-lazy-eval-then-some
branch
from
12eb1d3 to
9059bb2
Compare
|
|
joshtriplett
force-pushed
the
unnecessary-lazy-eval-then-some
branch
from
9059bb2 to
b7230d4
Compare
|
@flip1995 Done. |
|
@bors r+ Thanks! |
|
📌 Commit b7230d4 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9097
changelog: Extend
unnecessary_lazy_evalto convertbool::thentobool::then_some