Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 9, 2025

Fixes #13365

Pretty much the exact approach described in #13365 (comment), thank you @Jarcho!
r? @Jarcho

changelog: [collapsible_if]: respect #[expect] on inner if
changelog: [collapsible_else_if]: respect #[expect] on inner if

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 16, 2025
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarcho Jarcho added this pull request to the merge queue Sep 25, 2025
Merged via the queue into rust-lang:master with commit 4b236fc Sep 25, 2025
11 checks passed
@ada4a ada4a deleted the collapsible_if branch September 25, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive with expect(clippy::collapsible_else_if) inside the else block
3 participants