Skip to content

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Aug 28, 2025

Closes #15576

changelog: [numbered arg] fix wrong suggestions for inline literal following a numbered arg

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 28, 2025
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The code looks good to me. For (my) peace of mind, could you also add the following two tests to the new test function?

    println!("Hello {} is {:.p$}", "x", 0.01, p = 5);
    //~^ print_literal

    println!(
        "Hello {}: {2} is {3:.*} (which {3} with {1} places)",
        "name", 5, "x", 0.01
    );
    //~^^ print_literal

r? samueltardieu
@rustbot author

@rustbot rustbot assigned samueltardieu and unassigned Alexendoo Aug 28, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@profetia profetia requested a review from samueltardieu August 28, 2025 14:46
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 28, 2025
@profetia
Copy link
Contributor Author

Done. Thank you!

@samueltardieu samueltardieu added this pull request to the merge queue Aug 28, 2025
@samueltardieu
Copy link
Member

Thanks!

Merged via the queue into rust-lang:master with commit 1a7127c Aug 28, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 28, 2025
@profetia profetia deleted the issue15576 branch September 12, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print_literal causes semantic change when inlined literal is succeeded by a numbered arg
4 participants