double_parens: add structured suggestions, fix bug
#15420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ada4a
commented
Aug 10, 2025
rustbot
removed
the
S-waiting-on-review
ada4a
changed the title
double_parensdouble_parens: add structured suggestions, fix bug
rustbot
added
the
S-waiting-on-review
|
@Jarcho friendly ping |
Jarcho
requested changes
Sep 27, 2025
rustbot
added
S-waiting-on-author
ada4a
force-pushed
the
double-parens
branch
from
2194694 to
b613be2
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue that I saw made me rethink the lint design by quite a lot, so I decided to include that change in this PR
fixes #9000
changelog: [
double_parens]: add structured suggestionschangelog: [
double_parens]: fix FP when macros are involved