Skip to content

Fixunnecessary_safety_comment does not lint for the first line #15354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

Fixunnecessary_safety_comment does not lint for the first line #15354

merged 1 commit into from
Aug 22, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jul 27, 2025 •
edited by rustbot
Loading

Closes #14553
Closes #14554

changelog: [unnecessary_safety_comment] fix FN for the first line in file

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2025 •
edited
Loading

Lintcheck changes for f4c6ab0

Lint Added Removed Changed
clippy::unnecessary_safety_comment 1 0 0

This comment will be updated if you push new changes

@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned flip1995 and unassigned blyxyas Aug 11, 2025
flip1995
flip1995 reviewed Aug 13, 2025
View reviewed changes
@profetia profetia requested a review from flip1995 August 14, 2025 03:26
@flip1995
Copy link
Member

flip1995 commented Aug 21, 2025 •
edited
Loading

The lintcheck shows a FP after this change. https://docs.rs/ppv-lite86/0.2.17/src/ppv_lite86/lib.rs.html#8

@profetia profetia closed this Aug 21, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2025
@profetia profetia reopened this Aug 21, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2025
@profetia
Copy link
Contributor Author

I dont think it is caused by this pr. I rolled its back and it still happens (See the lintcheck run)

@flip1995
Copy link
Member

Thanks for testing this

@flip1995 flip1995 added this pull request to the merge queue Aug 22, 2025
Merged via the queue into rust-lang:master with commit 6d89c55 Aug 22, 2025
39 of 42 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
@ojeda ojeda mentioned this pull request Jul 24, 2025
Open
61 tasks
@profetia profetia deleted the issue14553 branch September 12, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 Awaiting requested review from flip1995

Assignees

@flip1995 flip1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_safety_comment does not lint the first item of a module without a body unnecessary_safety_comment does not lint for the first line
4 participants
@profetia @rustbot @flip1995 @blyxyas