Skip to content

Conversation

manoj23
Copy link
Contributor

@manoj23 manoj23 commented May 15, 2025

Clippy should not lint 2 blocks expression for comparison_chain.

Fixes #4725

changelog: [comparison_chain]: do not lint 2 blocks expression

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 15, 2025
@rustbot

This comment has been minimized.

Clippy should not lint 2 blocks expression for comparison_chain.
@manoj23
Copy link
Contributor Author

manoj23 commented May 15, 2025

r? @llogiq

@rustbot rustbot assigned llogiq and unassigned blyxyas May 15, 2025
@manoj23
Copy link
Contributor Author

manoj23 commented May 15, 2025

cc @czoia

@llogiq
Copy link
Contributor

llogiq commented May 16, 2025

Thank you. If memory serves, comparison_chain is one of the more allowed lints we have, so reducing its churn is definitely a plus.

@llogiq llogiq added this pull request to the merge queue May 16, 2025
Merged via the queue into rust-lang:master with commit 95d7eda May 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should comparison_chain only trigger for "if x > y {} else if x <y {} else {}" ?
4 participants