Skip to content

ignore array from deref_addrof lint #12864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2024
Merged

ignore array from deref_addrof lint #12864

merged 2 commits into from
May 30, 2024

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 29, 2024

Split from #12854

changelog: ignore array from deref_addrof lint

r? y21

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 29, 2024
@tesuji tesuji mentioned this pull request May 29, 2024
Closed
y21
y21 approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit and commits squashed

@tesuji
ignore array from deref_addrof lint
8bd2a17 
Note that semantics of repeat expr in array are the same
@tesuji
Copy link
Contributor Author

tesuji commented May 30, 2024

I squashed the fixing commit but leaved out the adding test commit.
That test is to show differences before and after the main change.

I reworded the comment to more detail. Could you take another look?

@y21
Copy link
Member

y21 commented May 30, 2024

Looks good now. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 30, 2024

📌 Commit 8bd2a17 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 30, 2024

⌛ Testing commit 8bd2a17 with merge 03654ba...

@bors
Copy link
Contributor

bors commented May 30, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 03654ba to master...

@bors bors merged commit 03654ba into rust-lang:master May 30, 2024
@tesuji tesuji deleted the non-no-effect branch May 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tesuji @y21 @bors @rustbot