Allow constant expressions that doesn't fit in i64. #3301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyp
force-pushed
the
u64_const
branch
5 times, most recently
from
93cea86 to
d4a2756
Compare
emilio
requested changes
Oct 2, 2025
There was a problem hiding this comment.
Looks fine, but I think we should document the setup because we're doing something rather subtle. Please double-check this is well defined in Rust (I can't do the digging right now but I could later if you need me to).
Alternatively, we need to change as_int to be a bit more complicated (something like enum IntEvaluationResult { Signed(i64), Unsigned(u64), None } or so).
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2618