Skip to content

Fix core testing #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Fix core testing #89

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44d8381
Remove --lib from the core test commands
bjorn3 Feb 26, 2025
af7d065
Test coretests instead of core for regular tests
bjorn3 Feb 26, 2025
c7ba645
Add comment why coretests is tested rather than core
bjorn3 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ci-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,16 @@ core)
# A 64bit little-endian and a 32bit big-endian target.
# (Varying the OS is totally pointless for core.)
for TARGET in x86_64-unknown-linux-gnu mips-unknown-linux-gnu; do
echo "::group::Testing core ($TARGET, no validation, no Stacked Borrows, symbolic alignment)"
# There are no library tests in core, and the integration tests are in a separate crate.
echo "::group::Testing coretests ($TARGET, no validation, no Stacked Borrows, symbolic alignment)"
MIRIFLAGS="$DEFAULTFLAGS -Zmiri-disable-validation -Zmiri-disable-stacked-borrows -Zmiri-symbolic-alignment-check" \
./run-test.sh core --target $TARGET --lib --tests \
./run-test.sh coretests --target $TARGET --tests \
-- --skip align \
2>&1 | ts -i '%.s '
echo "::endgroup::"
echo "::group::Testing core ($TARGET)"
echo "::group::Testing coretests ($TARGET)"
MIRIFLAGS="$DEFAULTFLAGS" \
./run-test.sh core --target $TARGET --lib --tests \
./run-test.sh coretests --target $TARGET --tests \
2>&1 | ts -i '%.s '
echo "::endgroup::"
echo "::group::Testing core docs ($TARGET)" && echo
Expand Down