Replace Google Charts with Chart.js #3141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this branch is currently deployed on the staging server: https://staging.crates.io/crates/foo |
Turbo87
force-pushed
the
chart-js
branch
3 times, most recently
from
af39b72 to
2d28be9
Compare
|
☔ The latest upstream changes (presumably #3145) made this pull request unmergeable. Please resolve the merge conflicts. |
jtgeibel
approved these changes
Dec 31, 2020
|
@bors r+ |
|
📌 Commit b1a090a has been approved by |
|
☀️ Test successful - checks-actions |
jtgeibel
added a commit
to jtgeibel/foundation.rust-lang.org
that referenced
this pull request
Apr 16, 2021
As of rust-lang/crates.io#3141, crates.io now self-hosts Chart.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Charts is the cause of a significant number of issues on Sentry, and generally it feels bad to load 3rd-party code that could potentially be used for user tracking.
This PR replaces our Google Charts usage in the Crate downloads graph with https://www.chartjs.org/. It looks slightly different and does not show the average values yet, but IMHO this is a good first step. Compared to the old implementation it now also has basic error handling and a loading state built-in, and these states are properly unit tested too.
r? @jtgeibel