Migrate from ember-css-modules to ember-scoped-css
#11523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
scoped-css
branch
6 times, most recently
from
3b84edf to
86aeb39
Compare
Turbo87
added
A-frontend 🐹
C-internal 🔧
Turbo87
force-pushed
the
scoped-css
branch
3 times, most recently
from
7efb8e5 to
f1f7083
Compare
eth3lbert
approved these changes
Jul 26, 2025
There was a problem hiding this comment.
I have to admit that I only inspected the deleted files and noticed they were just moved to a new folder and rewritten with CSS @layer. For the others, I only took a brief look, but given that the Percy visual snapshot doesn't show major differences, I believe this should all work well! Although some changes, like browserlist and normalize.css, could probably be split into separate commits, it's not really a big deal. And I love the change that we no longer need the local-class, we just need to place the CSS file beside the component which looks more natural. So, overall, LGTM 👍 Thanks for the work! :D
And don't forget, there's still a lock conflict before merging 😉
The former isn't particularly well maintained anymore and blocks all sorts of other migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former isn't particularly well maintained anymore and blocks all sorts of other migration.
see https://github.com/soxhub/ember-scoped-css/