Fix remove_nonexistent_team() test
#10576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was supposed to check what happens when a user removes a team owner that no longer exists on GitHub. But the test never added the team as a crate owner in the first place, which resulted in it not actually testing the relevant removal process. This commit fixes the issue by adding the corresponding row in the `crate_owners` database table.
Turbo87
added
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was supposed to check what happens when a user removes a team owner that no longer exists on GitHub. But the test never added the team as a crate owner in the first place, which resulted in it not actually testing the relevant removal process. This commit fixes the issue by adding the corresponding row in the
crate_ownersdatabase table.Related: