Skip to content

docs(change): Don't mention non-existent workspace.badges #14042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

docs(change): Don't mention non-existent workspace.badges #14042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
### Changed

- ❗️ manifest: Disallow `[badges]` to inherit from `[workspace.package.badges]`.
This was considered a bug and should inherit from `[workspace.badges]`.
This was considered a bug.
Keep in mind that `[badges]` is effectively deprecated.
Comment on lines +97 to 98
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

Suggested change
This was considered a bug.
Keep in mind that `[badges]` is effectively deprecated.
The support of it was considered a bug, since `[badges]` is deprecated.

Either is fine. r=me when ready.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That implies a causation which isn't there.

[#13788](https://github.com/rust-lang/cargo/pull/13788)
- build-script: Suggest old syntax based on MSRV.
Expand Down