Skip to content

inline Settings into Config #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2024
Merged

inline Settings into Config #886

merged 2 commits into from
Nov 11, 2024
+103 −45

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Nov 11, 2024 •
edited
Loading

move html_url into Settings as device-specific

cc @romancardenas

@burrbull burrbull force-pushed the settings branch 3 times, most recently from 7916121 to f1cc671 Compare November 11, 2024 16:28
romancardenas
romancardenas approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burrbull burrbull marked this pull request as ready for review November 11, 2024 17:36
@burrbull burrbull requested a review from a team as a code owner November 11, 2024 17:36
@burrbull burrbull added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 660f3dd Nov 11, 2024
46 checks passed
@burrbull burrbull deleted the settings branch November 11, 2024 19:20
@jessebraham jessebraham mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

+1 more reviewer

@romancardenas romancardenas romancardenas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burrbull @Emilgardis @romancardenas