Skip to content

Improve MSP430 documentation. #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2022
Merged

Improve MSP430 documentation. #653

merged 2 commits into from
Sep 4, 2022

Conversation

cr1901
Copy link
Contributor

@cr1901 cr1901 commented Sep 3, 2022

The improvements are twofold:

  1. Preemptively state that msp430 and msp430-rt 0.4.x are required. Neither are released as of this writing, but will be soon; they will use the critical_section crate.
  2. Improve describing how to generate an MSP430 SVD in the first place.

@cr1901 cr1901 requested a review from a team as a code owner September 3, 2022 02:55
@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Sep 3, 2022
@burrbull
Copy link
Member

burrbull commented Sep 4, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 4, 2022

Build succeeded:

@bors bors bot merged commit b3457d7 into rust-embedded:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cr1901 @rust-highfive @burrbull @ryankurte