avm1: Fix 21703 #21725
Open
avm1: Fix 21703 #21725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `.object` on a `DisplayObject` returns `Undefined` then `MovieClipReference::try_from_stage_object` will fail, create a pure string-path reference in this case. Fixes ruffle-rs#21703
kjarosh
added
A-avm1
|
Can we add a test for that? The new path is not covered by tests. |
|
Do we really want to block changes to any part of the code base that just happens to not already be covered almost entirely by tests (and the SWF kind specifically, at that)? |
|
(Or is the check not meant to "fail" if it could post the comment?) |
The check is failing only because the comment cannot be posted, the point of the comment was to allow maintainers to assess whether we should add tests or not, and not introduce a hard failure. In this case the newly added piece of code is untested, and the points from the comment that did not get posted apply :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
.objecton aDisplayObjectreturnsUndefinedthenMovieClipReference::try_from_stage_objectwill fail. Create a pure string-path reference in this case rather than panicking.Fixes #21703