-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added asymingt to committers list #5908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/18161200951/artifacts/4155864282. To view the resulting site:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix looks good, this has been approved by PMC meeting? just checking, i do not have any objections.
It was approved the 24th June 2025 |
Signed-off-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 3b33114)
Signed-off-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 3b33114)
Signed-off-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 3b33114)
(cherry picked from commit 3b33114) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 3b33114) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 3b33114) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Do you mind to check that your details is correct ? @asymingt