Skip to content

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 1, 2025

Do you mind to check that your details is correct ? @asymingt

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde requested a review from asymingt October 1, 2025 11:47
@ahcorde ahcorde self-assigned this Oct 1, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde added the backport-all backport at reviewers discretion; from rolling to all versions label Oct 1, 2025
Copy link

github-actions bot commented Oct 1, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/18161200951/artifacts/4155864282.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5908/index.html in your favorite browser

Copy link
Member

@asymingt asymingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 👍

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix looks good, this has been approved by PMC meeting? just checking, i do not have any objections.

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 2, 2025

the fix looks good, this has been approved by PMC meeting? just checking, i do not have any objections.

It was approved the 24th June 2025

@ahcorde ahcorde merged commit 3b33114 into rolling Oct 2, 2025
9 of 13 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/asymingt branch October 2, 2025 09:49
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 3b33114)
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 3b33114)
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 3b33114)
ahcorde added a commit that referenced this pull request Oct 2, 2025
(cherry picked from commit 3b33114)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Oct 2, 2025
(cherry picked from commit 3b33114)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Oct 2, 2025
(cherry picked from commit 3b33114)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants