Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 29, 2025

The pluginlib page has some issues.

First, I don't think that the area_node should be part of the library: add_library(${PROJECT_NAME} SHARED src/area_node.cpp)
As proposed here I changed it to be an INTERFACE library.

As a consequence,

ament_export_libraries(
      ${PROJECT_NAME}
    )

does not work any more.

Additionally,

    install(
      DIRECTORY include/
      DESTINATION include
    )

was a duplicate with different destination.


This is an automatic backport of pull request #5894 done by Mergify.

Signed-off-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit c87aa57)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Pluginlib.rst
Copy link
Contributor Author

mergify bot commented Sep 29, 2025

Cherry-pick of c87aa57 has failed:

On branch mergify/bp/jazzy/pr-5894
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit c87aa57.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   source/Tutorials/Beginner-Client-Libraries/Pluginlib.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Sep 29, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/18096321414/artifacts/4131826088.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5899/index.html in your favorite browser

@ahcorde ahcorde merged commit 27015cc into jazzy Sep 29, 2025
5 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-5894 branch September 29, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants