GADT-based representation of module / module types. #19943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
approved these changes
Dec 16, 2024
|
Hmm, this compiles on my machine. |
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
module-expr-type-gadt
branch
from
d3576bf to
865207b
Compare
coqbot-app
bot
removed
the
request: full CI
|
Let's try like this, it's more robust to unification changes. |
|
Some of the CI failures are spurious, I guess there were network failures. |
SkySkimmer
added
the
needs: overlay
ppedrot
added a commit
to ppedrot/coq-lsp
that referenced
this pull request
Dec 17, 2024
ppedrot
added a commit
to ppedrot/paramcoq
that referenced
this pull request
Dec 17, 2024
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
module-expr-type-gadt
branch
from
865207b to
4b0b4e9
Compare
coqbot-app
bot
removed
the
request: full CI
This reflects statically the fact that there are only two kinds of module-like expressions. Before we had a generic parameter, requiring passing around map functions and enforcing less invariants.
ppedrot
added a commit
to ppedrot/coq-lsp
that referenced
this pull request
Dec 18, 2024
ppedrot
force-pushed
the
module-expr-type-gadt
branch
from
4b0b4e9 to
9eb5738
Compare
coqbot-app
bot
added
the
needs: full CI
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
ppedrot
removed
the
needs: overlay
|
@SkySkimmer CI green. |
|
@coqbot merge now |
|
@SkySkimmer: Please take care of the following overlays:
|
SkySkimmer
added a commit
to ejgallego/coq-lsp
that referenced
this pull request
Dec 19, 2024
SkySkimmer
added a commit
to rocq-community/paramcoq
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects statically the fact that there are only two kinds of module-like expressions. Before we had a generic parameter, requiring passing around map functions and enforcing less invariants.
Overlays: