fix(examples): update installation instructions + cors origin url #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1140
Why
Tried to run the examples from a fresh git clone using the existing example instructions and wasn't able to.
npm install
gave the following error:pnpm install
so I tried that and it worked.@rivetkit/react
package:pnpm run build
from the root directory of the repo.localhost:3000
(rather than the default which islocalhost:5173
). Updating the cors origin url in theserver.ts
files for these examples fixed the issue and made them work.What does this PR do
README.md
files (for all examples) with the instructions that workedPut them in separate commits bc you could also update the
vite.config.ts
server port url to fix the issue instead of updating the cors origin url inserver.ts
. Wasn't sure which would be preferred — seemed like the newer examples use the explicit port 3000 so decided to update the cors url.