Skip to content

Conversation

sudo-apt-abdullah
Copy link
Contributor

No description provided.

@sudo-apt-abdullah sudo-apt-abdullah changed the title Removed the tags "Elsewhere" fix: removed the tags "Elsewhere" Sep 29, 2025
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (5d6c397) to head (7c34b30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1138   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          11       11           
  Lines        4942     4942           
  Branches     1345     1345           
=======================================
  Hits         2276     2276           
  Misses       2666     2666           
Flag Coverage Δ
idlc 46.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The manual assumes a basic familiarity with computer architecture and programming concepts, but provides background information and references for further study.
This section is only included for educational distributions.
when(): "distribution_type == 'educational'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous content, this when() method applied only to the preceding line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous content, this when() method applied only to the preceding line.

I'm sorry, but I couldn't get it. Can you please elaborate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content without the changes here is:

      - id: sec-preface-audience-conditional
        normative: false
        text: |
          This section is only included for educational distributions.
        when(): "distribution_type == 'educational'"

So, the when() conditional only applies to that single line.

With these changes, I think that the "description" is still defined as an array of "tagged_text", but that definition was renamed to "conditional_text", so I'm a bit confused how the CI tests passed. I must be missing something.

Anyway, in these changes, the when() clause is associated with all of the previous text, which is not desired.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some tagged description with when(): condition, especially in hstatus.yaml. So, I updated the definition from tagged_text to conditional_text after removing tags, so that it can make more sense now.

@ThinkOpenly ThinkOpenly changed the title fix: removed the tags "Elsewhere" fix: remove all tagging from descriptions Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants