-
Notifications
You must be signed in to change notification settings - Fork 76
fix: remove all tagging from descriptions #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The manual assumes a basic familiarity with computer architecture and programming concepts, but provides background information and references for further study. | ||
This section is only included for educational distributions. | ||
when(): "distribution_type == 'educational'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous content, this when()
method applied only to the preceding line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous content, this
when()
method applied only to the preceding line.
I'm sorry, but I couldn't get it. Can you please elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content without the changes here is:
- id: sec-preface-audience-conditional
normative: false
text: |
This section is only included for educational distributions.
when(): "distribution_type == 'educational'"
So, the when()
conditional only applies to that single line.
With these changes, I think that the "description" is still defined as an array of "tagged_text", but that definition was renamed to "conditional_text", so I'm a bit confused how the CI tests passed. I must be missing something.
Anyway, in these changes, the when()
clause is associated with all of the previous text, which is not desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some tagged description with when():
condition, especially in hstatus.yaml
. So, I updated the definition from tagged_text to conditional_text after removing tags, so that it can make more sense now.
97c147e
to
7c34b30
Compare
No description provided.