Strip empty fields in MultipartEncoder #326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is coherent with what's done in requests
rdbisme
force-pushed
the
empty-files-key-multipart
branch
from
2da4582 to
f8d7dfe
Compare
|
Up? :) |
Cast to bytes if comparing to another bytes body Reference: https://github.com/getsentry/responses/blob/ebcb65f52e055e1d44289924b7e7d0be4b2a51db/responses/matchers.py#L301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is coherent with what's done in requests. My usecase concerns using responses.matchers.multipart_matcher, which uses bare requests to encode the multipart request, while the client, that specifically is Gitlab's one, uses
MultipartEncoder. The two bodies for the request do not match