fix: use stable array to prevent memoization issue in useList #7019 #7020
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 04a9e40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The commit 43afc44 also update |
alicanerdurmaz
requested changes
Sep 23, 2025
alicanerdurmaz
requested changes
Sep 23, 2025
There was a problem hiding this comment.
Thanks for the improving Refine,
we need changeset to release this fix
Thanks for your feedback. I'll add the changeset. |
alicanerdurmaz
approved these changes
Sep 24, 2025
alicanerdurmaz
requested changes
Sep 25, 2025
alicanerdurmaz
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
In commit 43afc44, the useList hook returns a new, empty array [] on every render cycle whenever queryResponse.data.data is falsy. This violates referential equality, causing hooks like useMemo and useEffect to re-calculate unnecessarily, leading to potential performance degradation.
What is the new behavior?
The useList hook now returns a stable, frozen empty array Object.freeze([]) as the default value for result.data.
fixes #7019
Notes for reviewers