Skip to content

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Extracting maintenance push notifications logic into separate abstract classes. Using multiple inheritance for Connection and ConnectionPool classes to expose the maintenance push notifications for the existing connections.

…classes. Usingle multiple inheritance for Connection and ConnectionPool classes to expose the maintenance push notifications for the existing connections.
@petyaslavova petyaslavova requested a review from Copilot October 2, 2025 18:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the maintenance push notifications code by extracting logic into separate abstract classes and using multiple inheritance to expose maintenance push notifications for existing Connection and ConnectionPool classes.

  • Introduced abstract classes for maintenance push notifications functionality
  • Updated connection handling to use the new _get_socket() method instead of direct _sock access
  • Modified test configurations to support cache configurations and different connection types

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/test_maint_notifications_handling.py Updated test methods to use new socket access patterns and added cache configuration support
tests/test_maint_notifications.py Added socket import and updated MockConnection to inherit from new abstract class
redis/maint_notifications.py Updated type hints to use new MaintNotificationsAbstractConnection instead of ConnectionInterface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant