Skip to content

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames "maintenance events" to "maintenance notifications" throughout the codebase to better reflect that these are notifications about maintenance activities rather than the events themselves.

Key changes:

  • Renamed classes, methods, and variables containing "maintenance events" or "maint events" to use "maintenance notifications" or "maint notifications"
  • Updated configuration parameter names from "relax_timeout" to "relaxed_timeout"
  • Updated comments and documentation to reflect the new terminology

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_scenario/test_hitless_upgrade.py Updated test fixtures and variable names to use maintenance notifications terminology
tests/test_scenario/conftest.py Renamed configuration helper functions and parameters to use notifications terminology
tests/test_maintenance_events_handling.py Comprehensive rename of test class names, methods, and variables from events to notifications
tests/test_maintenance_events.py Updated test classes and methods to use notification terminology throughout
redis/maintenance_events.py Core rename of classes, methods, and configuration from events to notifications
redis/connection.py Updated connection handling code to use notifications terminology and relaxed_timeout
redis/client.py Updated Redis client to use maint_notifications_config parameter
redis/_parsers/base.py Updated parser mapping and method names to use notifications terminology
Comments suppressed due to low confidence (3)

tests/test_scenario/conftest.py:1

  • The comment on line 958 is inconsistent with the comment on line 1010. Line 958 says connections will 'also receive the moving notification' but line 1010 says they 'will also receive the moving notification' - the context suggests line 958 should say 'will not receive the migrating notification' based on the surrounding code about disabled notifications.
import json

tests/test_maintenance_events_handling.py:1

  • [nitpick] The comment text is duplicated identically on lines 545 and 649. Consider making the comments more specific to their context or removing the duplication.
import socket

tests/test_maintenance_events_handling.py:1

  • [nitpick] The comment text is duplicated identically on lines 545 and 649. Consider making the comments more specific to their context or removing the duplication.
import socket

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@petyaslavova petyaslavova force-pushed the ps_rename_events_to_notifications branch from 9bb2eac to d932755 Compare September 24, 2025 10:18
@petyaslavova petyaslavova merged commit a0e4d3f into master Sep 24, 2025
60 of 61 checks passed
@petyaslavova petyaslavova deleted the ps_rename_events_to_notifications branch September 24, 2025 13:17
@petyaslavova petyaslavova added the breakingchange API or Breaking Change label Sep 24, 2025
zion-off pushed a commit to zion-off/redis-py that referenced this pull request Sep 25, 2025
* Rename relax_timeout to relaxed_timeout

* Rename to MaintNotificationsConnectionHandler, MaintNotificationsPoolHandler and MaintNotificationsConfig

* Completing renames - all tests are included as well as the rest of the class and object/field/args names

* Fixing errors after rebase.

* Fixing linters error related to too long arg name in abstract method
petyaslavova added a commit that referenced this pull request Sep 26, 2025
* Rename relax_timeout to relaxed_timeout

* Rename to MaintNotificationsConnectionHandler, MaintNotificationsPoolHandler and MaintNotificationsConfig

* Completing renames - all tests are included as well as the rest of the class and object/field/args names

* Fixing errors after rebase.

* Fixing linters error related to too long arg name in abstract method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange API or Breaking Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants