-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Adding handling of FAILING_OVER and FAILED_OVER events/push notifications #3716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding handling of FAILING_OVER and FAILED_OVER events/push notifications #3716
Conversation
… tests for maintenance_events.py file
…tion pool - this should be a separate PR
… Refactored the maintenance events tests not to be multithreaded - we don't need it for those tests.
…ot processed in in Moving state. Tests are updated
…ply them during connect
…isting ones more generic
…e better retry_on_error handling on connection initialization.
e8643cd
to
4c6eb44
Compare
8d7cc00
to
10ded34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the Redis maintenance events system to handle two new cluster failover events: FAILING_OVER
and FAILED_OVER
. These events complement the existing migration events (MIGRATING
/MIGRATED
) by providing handling for cluster node failover scenarios.
Key changes:
- Added two new event classes:
NodeFailingOverEvent
andNodeFailedOverEvent
- Integrated failover event handling into the existing maintenance event system using the same timeout relaxation mechanism as migration events
- Added comprehensive test coverage for the new events including integration tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
redis/maintenance_events.py | Added new failover event classes and integrated them into the event handler system |
tests/test_maintenance_events.py | Added unit tests for the new event classes and updated existing tests to use the generalized event handling methods |
tests/test_maintenance_events_handling.py | Added integration tests simulating failover events in the mock Redis communication layer |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
83f84cd
into
feat/hitless-upgrade-sync-standalone
…rade or maintenance procedures. (#3756) * Hitless upgrade: Support initial implementation for synchronous Redis client - no handshake, no failing over notifications support. (#3713) * Adding handling of FAILING_OVER and FAILED_OVER events/push notifications (#3716) * Hitless upgrade: Adding handshake command to enable the notifications after connection is established (#3735) * Hitless-Upgrade: Add handling of MOVING push notification with "null" host:port info. (#3751) --------- Co-authored-by: Elena Kolevska <[email protected]>
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Adding handling of FAILING_OVER and FAILED_OVER events/push notifications