Skip to content

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adding handling of FAILING_OVER and FAILED_OVER events/push notifications

@petyaslavova petyaslavova requested a review from Copilot July 24, 2025 15:07
Copilot

This comment was marked as outdated.

@petyaslavova petyaslavova marked this pull request as ready for review August 15, 2025 08:31
… Refactored the maintenance events tests not to be multithreaded - we don't need it for those tests.
…ot processed in in Moving state. Tests are updated
…e better retry_on_error handling on connection initialization.
@petyaslavova petyaslavova force-pushed the ps_hitless_upgrade_sync_redis branch from e8643cd to 4c6eb44 Compare August 15, 2025 14:35
@petyaslavova petyaslavova force-pushed the ps_add_fail_over_events_handling branch from 8d7cc00 to 10ded34 Compare August 15, 2025 14:37
Base automatically changed from ps_hitless_upgrade_sync_redis to feat/hitless-upgrade-sync-standalone August 18, 2025 07:57
@petyaslavova petyaslavova requested a review from Copilot August 18, 2025 08:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the Redis maintenance events system to handle two new cluster failover events: FAILING_OVER and FAILED_OVER. These events complement the existing migration events (MIGRATING/MIGRATED) by providing handling for cluster node failover scenarios.

Key changes:

  • Added two new event classes: NodeFailingOverEvent and NodeFailedOverEvent
  • Integrated failover event handling into the existing maintenance event system using the same timeout relaxation mechanism as migration events
  • Added comprehensive test coverage for the new events including integration tests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
redis/maintenance_events.py Added new failover event classes and integrated them into the event handler system
tests/test_maintenance_events.py Added unit tests for the new event classes and updated existing tests to use the generalized event handling methods
tests/test_maintenance_events_handling.py Added integration tests simulating failover events in the mock Redis communication layer
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@petyaslavova petyaslavova merged commit 83f84cd into feat/hitless-upgrade-sync-standalone Aug 19, 2025
1 check passed
@petyaslavova petyaslavova deleted the ps_add_fail_over_events_handling branch August 19, 2025 09:08
petyaslavova added a commit that referenced this pull request Aug 29, 2025
…rade or maintenance procedures. (#3756)

* Hitless upgrade: Support initial implementation for synchronous Redis client - no handshake, no failing over notifications support. (#3713)

* Adding handling of FAILING_OVER and FAILED_OVER events/push notifications (#3716)

* Hitless upgrade: Adding handshake command to enable the notifications after connection is established (#3735)

* Hitless-Upgrade: Add handling of MOVING push notification with "null" host:port info. (#3751)

---------

Co-authored-by: Elena Kolevska <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants