Add valid Exception type to Except in ClusterPipeline #3516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bssyousefi thank you for your contribution! We’ll review your change soon. |
petyaslavova
added
breakingchange
petyaslavova
pushed a commit
to Kakadus/redis-py
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for the repo.
In a recent change in
ClusterPipeline,TimeoutErrorhas been added to reinitialize the nodes.redis-py/redis/cluster.py
Line 2188 in 799716c
However, it's a nested
try-exceptand the upperexceptshould also containTimeoutErrorin order to respectcluster_error_retry_attempts.redis-py/redis/cluster.py
Line 2115 in 799716c