Skip to content

Add tracing hooks for existing connections #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add tracing hooks for existing connections #3432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion extra/redisotel/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const (
instrumName = "github.com/redis/go-redis/extra/redisotel"
)

func InstrumentTracing(rdb redis.UniversalClient, opts ...TracingOption) error {
func InstrumentTracing(ctx context.Context, rdb redis.UniversalClient, opts ...TracingOption) error {
switch rdb := rdb.(type) {
case *redis.Client:
opt := rdb.Options()
Expand All @@ -36,6 +36,14 @@ func InstrumentTracing(rdb redis.UniversalClient, opts ...TracingOption) error {
connString := formatDBConnString(opt.Network, opt.Addr)
rdb.AddHook(newTracingHook(connString, opts...))
})

rdb.ForEachShard(ctx, func(ctx context.Context, rdb *redis.Client) error {
opt := rdb.Options()
opts = addServerAttributes(opts, opt.Addr)
connString := formatDBConnString(opt.Network, opt.Addr)
rdb.AddHook(newTracingHook(connString, opts...))
return nil
})
return nil
case *redis.Ring:
rdb.OnNewNode(func(rdb *redis.Client) {
Expand All @@ -44,6 +52,14 @@ func InstrumentTracing(rdb redis.UniversalClient, opts ...TracingOption) error {
connString := formatDBConnString(opt.Network, opt.Addr)
rdb.AddHook(newTracingHook(connString, opts...))
})

rdb.ForEachShard(ctx, func(ctx context.Context, rdb *redis.Client) error {
opt := rdb.Options()
opts = addServerAttributes(opts, opt.Addr)
connString := formatDBConnString(opt.Network, opt.Addr)
rdb.AddHook(newTracingHook(connString, opts...))
return nil
})
return nil
default:
return fmt.Errorf("redisotel: %T not supported", rdb)
Expand Down
Loading