bug: Fix SETINFO ensuring it is set-and-forget #2915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 19, 2024
|
@ofekshenawa How about disabling identity by default as mentioned in #2880 (comment)? guess most of the users are running Redis < 7.2 and enabling this may affect the performance of the connect stage. |
dvora-h
reviewed
Feb 20, 2024
dvora-h
previously approved these changes
Feb 20, 2024
chayim
changed the title
chayim
changed the title
This was referenced Feb 20, 2024
chayim
approved these changes
Feb 20, 2024
dvora-h
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating SETINFO so that when it is sent, it is set-and-forget. This enabled SETINFO to run only where appropriate (i.e redis 7.2+). Once ready, this release should:
closes #2910
closes #2911
closes #2914